Fix localAddress test on OS X #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't test the error message because on OS X it's EADDRNOTAVAIL instead of EINVAL.
Closed
|
👍 looks good to me |
|
👍 works for me |
nylen
pushed a commit
to nylen/request
that referenced
this pull request
Oct 17, 2014
Fix localAddress test on OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't test the error message because on OS X it's EADDRNOTAVAIL instead of EINVAL. (We leave in the test that an error occurs, and the message wasn't tested before the test suite rewrite either.)
Would appreciate confirmation from @mikeal / @seanstrom / @emkay that this works as intended. If so, this fixes #1148.