Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): no-proxy false positive #1295

Merged
merged 1 commit into from Nov 28, 2014

Conversation

Projects
None yet
2 participants
@oliamb
Copy link
Contributor

commented Nov 28, 2014

If one of the no-proxy item is exactly one character longer than the
request URL, it was considered as a valid match for no-proxy case
detection.

This patch handle the special (-1) value to close issue #1294.

Olivier Amblet
fix(proxy): no-proxy false positive
If one of the no-proxy item is exactly one character longer than the
request URL, it was considered as a valid match for no-proxy case
detection.

This patch handle the special (-1) value.
@nylen

This comment has been minimized.

Copy link
Member

commented Nov 28, 2014

👍 thanks!

nylen added a commit that referenced this pull request Nov 28, 2014

Merge pull request #1295 from oliamb/fix-issue-1294
fix(proxy): no-proxy false positive

@nylen nylen merged commit 8f2ded1 into request:master Nov 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.