Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forever option in node > 0.10 #1709 #1715

Merged
merged 1 commit into from Aug 10, 2015

Conversation

Projects
None yet
3 participants
@calibr
Copy link
Contributor

commented Aug 5, 2015

Fixes #1709

Makes forever option work fine in node > 0.10, so now it doesn't create new agent every request, and reuse old agents. Issue #1709.

@calibr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2015

hm test fails on fresh iojs v3, but it also fails on master branch with this io version on my local computer...

@simov

This comment has been minimized.

Copy link
Member

commented Aug 5, 2015

Looking good to me 👍

@simov simov changed the title fix forever option in node > 0.10 #1709 Fix forever option in node > 0.10 #1709 Aug 10, 2015

simov added a commit that referenced this pull request Aug 10, 2015

Merge pull request #1715 from calibr/forever-fix2
Fix forever option in node > 0.10 #1709

@simov simov merged commit 289106d into request:master Aug 10, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@aamirafridi

This comment has been minimized.

Copy link

commented on index.js in ae403dc Aug 20, 2015

You need to check options before trying to get .pool

It took me hours to find the issue. See this 58e8f53#commitcomment-12808032

This comment has been minimized.

Copy link
Member

replied Aug 20, 2015

Fixed here #1743

@omsmith omsmith referenced this pull request Sep 3, 2015

Closed

Update request #4260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.