Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create Buffer from Object in setContentLength(iojs v3.0 issue) #1716

Merged
merged 1 commit into from Aug 10, 2015

Conversation

Projects
None yet
2 participants
@calibr
Copy link
Contributor

commented Aug 5, 2015

Due to changes in io.js v3.0 creating Buffer from Object throws an Error. This PR just prevents this

@simov simov changed the title do not create Buffer from Object in setContentLength(iojs v3.0 issue) Do not create Buffer from Object in setContentLength(iojs v3.0 issue) Aug 10, 2015

simov added a commit that referenced this pull request Aug 10, 2015

Merge pull request #1716 from calibr/iojs-error-fix
Do not create Buffer from Object in setContentLength(iojs v3.0 issue)

@simov simov merged commit 30c7df5 into request:master Aug 10, 2015

3 checks passed

codecov/commit 100.00% (min required 80.00%)
Details
codecov/project 88.25% (min required 80.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simov

This comment has been minimized.

Copy link
Member

commented Aug 10, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.