Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a simple Response object reference in argument specification #2221

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
2 participants
@calamarico
Copy link
Contributor

commented May 24, 2016

When i read request arguments specification for first time, i didn't recognize that IncomingMessage is created by ClientRequest and passed as the first argument 'request' or 'response', i think this reference in readme improve this great package :D

@FredKSchott FredKSchott added abandoned and removed abandoned labels Feb 22, 2017

@FredKSchott

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2017

Thanks @calamarico!

@FredKSchott FredKSchott merged commit 6862553 into request:master Feb 22, 2017

2 checks passed

codecov/project 91.18% compared to 1b19c88
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.