Multipart content-type change #224

merged 1 commit into from Apr 5, 2012


None yet

2 participants


I am currently using request to do some multipart work and I notice that there are some parsers that don't like the way request formats it multipart headers. I especially think of Ruby, but it might be a coincidence.

The changes here are small and shouldn't break compatibility.

  1. In RFC1341 the quotes are omitted in all cases but one, when there was a space in the identifier. Let's remove that as some sucky parsers fall over it, it won't make a difference because according to RFC2045 the quotes are optional.
  2. I have no clue whether the the space after the ; is mandatory, I can't really find anything in the RFC's (but then again, I'm a sloppy reader), but I have noticed that some parsers (like CloudFoundry) break over this if the space is omitted.
@mikeal mikeal merged commit d853e53 into request:master Apr 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment