New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #2197, handling of deflate encoding with older servers #2335

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@czardoz
Contributor

czardoz commented Aug 16, 2016

Haven't added tests yet, will add them if this change is welcome 馃槃

@czardoz czardoz force-pushed the czardoz:master branch from 560272b to 7cdd4d4 Aug 17, 2016

Aniket Panse
@czardoz

This comment has been minimized.

Contributor

czardoz commented Aug 18, 2016

Ping @simov :)

@gotojmp

This comment has been minimized.

gotojmp commented Sep 30, 2016

Good job.

@FredKSchott

This comment has been minimized.

Contributor

FredKSchott commented Feb 22, 2017

This PR has been closed as "abandoned" as a part of an automated cleanup. If this is a mistake and you are still interested in merging this PR, please do the following:

  1. Rebase your changes onto the master branch (even if there are no merge conflicts, we want to make sure your change is under the most recent tests).
  2. Push your updated branch to Github to update this PR.
  3. Make sure this PR's Travis tests are still passing. (Run npm test locally if tests are still failing).
  4. Comment here to let us know that you've updated the PR and are still interested in getting it merged. Somebody from the project will respond and work with you to review.

Thank you for your understanding. If you have any questions, please check out #2556 and feel free to comment / ask anything there.

@mfrye

This comment has been minimized.

mfrye commented on 7cdd4d4 Mar 2, 2017

This is really smart. Thanks for this.

This comment has been minimized.

khadlock replied Feb 9, 2018

Many thanks for this!

This comment has been minimized.

Owner

czardoz replied Feb 9, 2018

@khadlock Welcome, someone has opened an upstream PR which you can track: request#2856

If you'd rather not wait, you can use https://github.com/postmanlabs/postman-request/ which is a drop in replacement for request (with a few other bugfixes as well).

This comment has been minimized.

khadlock replied Feb 9, 2018

@czardoz Great to know, thanks, I'll check those out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment