Fixing the set-cookie header #246

Merged
merged 1 commit into from Apr 30, 2012

Projects

None yet

2 participants

@jeromegn
Contributor

Sometimes the "set-cookie" response header wasn't parsed as an Array. This had the effect of throwing an error about the cookie string not having the forEach method.

I'm honestly not sure how to write a test for that with the current way tests are made. I'm also unsure where that header was converted to an Array in the first place.

This is tentative at best. I can't claim to know the intricacies of Request, but I'm willing to learn them if you point me in the right direction.

@mikeal mikeal merged commit 9611f4c into request:master Apr 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment