Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to safe-buffer for improved security. #2574

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
1 participant
@mikeal
Copy link
Member

commented Mar 4, 2017

Tests have run and passed locally but I'm curious to see what CI says because I haven't tested against older versions of Node.js yet.

I ended up having to push a quick release of tunnel-agent to cover this potential vulnerability fully. There are no tests for tunnel-agent so that only way to get any coverage was to push a release and then pull that new release into this PR.

@mikeal mikeal merged commit 7ec8b84 into master Mar 4, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 7b9ceef...f113253
Details
codecov/project 92.55% remains the same compared to 7b9ceef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mikeal mikeal deleted the safe-buffer branch Mar 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.