Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

swap out node's querystring lib for visionmedia's #319

Closed
wants to merge 3 commits into from

7 participants

Johnny Domino Mikeal Rogers Benjamin Horsleben Matt Liegey Adrian Lee Lindsey Bieda Angelo Di Paolo
Johnny Domino

visionmedia's querystring parser handles nested attributes and puts them into a common format (common among node-express, ruby on rails, etc)

qs.stringify({ user: { name: 'Tobi', email: 'tobi@learnboost.com' }})
// => user[name]=Tobi&user[email]=tobi%40learnboost.com

this makes it much easier to interact with such servers using node-request

Mikeal Rogers
Owner

hrm.... can you add qs to the tree with this pull request. as of node the bundle fails.

Johnny Domino

does adding qs to the node_modules folder accomplish what you wanted?

Benjamin Horsleben

bump. I would really prefer if this pull request made it. Just ran into the same issue, and it is driving me nuts.

Adrian Lee

+1 running into the same issue when stringifying nested objects. tj's library works for me

Johnny Domino merged upstream caa2391
Mikeal Rogers
Owner

this doesn't merge cleanly, please reopen when it does.

Mikeal Rogers mikeal closed this
Johnny Domino

Are you interested in accepting this if I do? It won't merge because node_modules changed; if it's not quickly merged in it's likely to be incompatible again.

Mikeal Rogers
Owner

right, node_modules are no longer checked in and i'm more inclined to accept dependencies.

so long as these extensions are within spec and won't break any existing code i'll merge it if it comes with a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 9, 2012
  1. replaced node\'s querystring with visionmedia\'s qs lib

    Johnny Domino authored
Commits on Oct 5, 2012
  1. added qs to node_modules

    Johnny Domino authored
Commits on Feb 6, 2013
  1. merged upstream

    Johnny Domino authored
Something went wrong with that request. Please try again.