swap out node's querystring lib for visionmedia's #319

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
7 participants

jmonster commented Sep 9, 2012

visionmedia's querystring parser handles nested attributes and puts them into a common format (common among node-express, ruby on rails, etc)

qs.stringify({ user: { name: 'Tobi', email: 'tobi@learnboost.com' }})
// => user[name]=Tobi&user[email]=tobi%40learnboost.com

this makes it much easier to interact with such servers using node-request

Owner

mikeal commented Sep 17, 2012

hrm.... can you add qs to the tree with this pull request. as of node the bundle fails.

jmonster commented Oct 5, 2012

does adding qs to the node_modules folder accomplish what you wanted?

fizker commented Nov 25, 2012

bump. I would really prefer if this pull request made it. Just ran into the same issue, and it is driving me nuts.

mattlgy commented Dec 20, 2012

👍

+1 running into the same issue when stringifying nested objects. tj's library works for me

LindseyB commented Feb 6, 2013

👍

Johnny Domino merged upstream caa2391

👍

Owner

mikeal commented Mar 1, 2013

this doesn't merge cleanly, please reopen when it does.

mikeal closed this Mar 1, 2013

jmonster commented Mar 1, 2013

Are you interested in accepting this if I do? It won't merge because node_modules changed; if it's not quickly merged in it's likely to be incompatible again.

Owner

mikeal commented Mar 1, 2013

right, node_modules are no longer checked in and i'm more inclined to accept dependencies.

so long as these extensions are within spec and won't break any existing code i'll merge it if it comes with a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment