Don't create a Content-Length header if we already have it set #361

Merged
merged 1 commit into from Nov 5, 2012

Projects

None yet

2 participants

@danjenkins
Contributor

We've had issues where we need to send Content-Length as a header, rather than content-length; when content-length lowercase is in the request, the request fails.

I've put some more checks around content-length so that request doesn't do this if we've already worked out Content-Length

I thought it was part of the HTTP spec that headers we in fact uppercase? According to RFC2616?

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

@mikeal mikeal merged commit 4a81507 into request:master Nov 5, 2012
@danjenkins
Contributor

Hi Mikeal, thanks for merging so quickly.

Is this likely to be released to npm soonish? Or would I be better pointing my package.json file to github for me to access this change?

Thanks,

Dan

@mikeal
Member
mikeal commented Nov 5, 2012

umn.... soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment