Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Running `rfc3986` on `base_uri` in `oauth.hmacsign` instead of just `encodeURIComponent` #362

Merged
merged 1 commit into from

2 participants

@jeffmarshall

All I've changed in terms of output is that the base_uri is encoded with the rfc3986 function before being included in the sha1 base. I was getting 401 errors with the LinkedIn API because my signatures were wrong when I used field selectors in an api call.

Jeff Marshall inside oauth.hmacsign: running rfc3986 on base_uri instead of just en…
…codeURIComponent.

Essentially, all I've really changed in terms of output is that the base_uri is
encoded with the rfc3986 function before being included in the sha1 base. I was
getting 401 errors with the LinkedIn API because my signatures were wrong when
I used [field selectors](https://developer.linkedin.com/documents/field-selectors)
in an api call.
590452d
@mikeal mikeal merged commit 32713ad into request:master
@mikeal
Owner

the oauth test no longer passes :(

@mikeal
Owner

if i don't get a fix in the next few hours i'm going to have to back this out.

@jeffmarshall

Ok, I'll have a look.

@mikeal mikeal referenced this pull request from a commit
@mikeal mikeal Revert "Merge pull request #362 from jeffmarshall/master"
This reverts commit 32713ad, reversing
changes made to 4a81507.
f7dc90c
@cybdoom cybdoom referenced this pull request from a commit in cybdoom/EbayAmazonApiServer
@cybdoom cybdoom