`node v0.9.x` compatibility #399

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
5 participants
Member

mmalecki commented Dec 30, 2012

This isn't ready to merge yet, merely heads up for everyone wanting to use request with unstable version of node.

Right now, streams2 compatibility is included. rejectUnauthorized in tests should still be changed.

Member

mmalecki commented Jan 3, 2013

7af1083 and fed0edb fixed most of the https tests. Still trying to figure out test-httpModule.

Member

mmalecki commented Feb 23, 2013

Can we consider this for merging? cc @mikeal @isaacs

Contributor

isaacs commented Feb 23, 2013

I think if strictSSL is set explicitly, then rejectUnauthorized should be set that way as well. Maybe just deprecate that option, and guide people towards using rejectUnauthorized instead?

Owner

mikeal commented Feb 23, 2013

this no longer merges cleanly.

Owner

mikeal commented Mar 1, 2013

this doesn't merge cleanly, please reopen when it does.

mikeal closed this Mar 1, 2013

nrn and others added some commits Mar 1, 2013

@nrn nrn Merge branch 'master' of github.com:mikeal/request b4c4c28
@mikeal mikeal Merge pull request #454 from mafintosh/master
Destroy the response if present when destroying the request (clean merge)
2242328
@mikeal mikeal Merge pull request #429 from nrn/master
Copy options before adding callback.
049cefa
@mmalecki mmalecki Call `response.resume()` to start the data flow
This fixes tests which were broken since introducing `streams2`.
4a26bf6
Member

mmalecki commented Mar 2, 2013

@mikeal this now merges cleanly, please reopen

mikeal reopened this Mar 2, 2013

Owner

mikeal commented Mar 2, 2013

if this doesn't break 0.8 i could just merge it now :)

Member

mmalecki commented Mar 13, 2013

This doesn't break 0.8 - tests still pass.

@kenperkins kenperkins commented on the diff Apr 11, 2013

@@ -1140,6 +1141,8 @@ function request (uri, options, callback) {
options = uri
}
+ options = copy(options)
@kenperkins

kenperkins Apr 11, 2013

Contributor

What's the reason to move options copy down?

mikeal closed this Apr 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment