Copy options before adding callback. #429

merged 2 commits into from Mar 2, 2013


None yet

2 participants

nrn commented Feb 6, 2013

Prevents a reference to the callback function being added to the original options object.

I discovered this by making a request with a callback, then reusing the options object I made the request with to make a streaming request, which called the callback a second time.

mikeal commented Mar 1, 2013

this doesn't merge cleanly, please reopen when it does.

@mikeal mikeal closed this Mar 1, 2013
nrn commented Mar 2, 2013

Seemed to merge cleanly with master, what can I do to help?

@mikeal mikeal reopened this Mar 2, 2013
@mikeal mikeal merged commit 049cefa into request:master Mar 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment