Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Copy options before adding callback. #429

Merged
merged 2 commits into from

2 participants

@nrn
nrn commented

Prevents a reference to the callback function being added to the original options object.

I discovered this by making a request with a callback, then reusing the options object I made the request with to make a streaming request, which called the callback a second time.

@mikeal
Owner

this doesn't merge cleanly, please reopen when it does.

@mikeal mikeal closed this
@nrn
nrn commented

Seemed to merge cleanly with master, what can I do to help?

@mikeal mikeal reopened this
@mikeal mikeal merged commit 049cefa into request:master
@cybdoom cybdoom referenced this pull request from a commit in cybdoom/EbayAmazonApiServer
@cybdoom cybdoom