Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove bundleDepdendencies from package.json to pull in latest versions of form-data and mime, also bump major version. #431

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

celer commented Feb 10, 2013

So I've been trying to fix a bug with request when using the multi-part forms where a form value of empty string will cause the everything to fail. So one by one I've been moving from package to package putting all the bits in to fix this.

The bug originated in node-combined-stream which is required by node-form-data which is required by request.

Bug in node-combined-stream:
felixge/node-combined-stream#4

Bug in node-form-data
felixge/node-form-data#25

And due to an issue with the package.json node-form-data needed to be updated as well. Now this bug has propagated all the way up to request being the next dependency in line :(

The fix to finally resolve this issue is to remove the line:

, "bundleDependencies":["form-data","mime"]

And to bump the package version for request up a major version as request will use much newer versions of form-data and mime.

If this is done I believe the following bugs in request will be resolved
#385
#424

And the following issues may be resolved
#394
#316

@celer celer referenced this pull request in form-data/form-data Feb 10, 2013

Closed

stream ended unexpectedly #25

Owner

mikeal commented Feb 10, 2013

I updated the bundle deps. I want to stick with locked bundelDependencies for request.

@mikeal mikeal closed this Feb 10, 2013

celer commented Feb 10, 2013

Thanks!

Will you be updating the package in NPM with a minor version bump?

Owner

mikeal commented Feb 10, 2013

master has some new auth code we're sitting on, making sure it all works and is backward compatible, before i push a new release. soon though, very soon.

celer commented Feb 10, 2013

Awesome!

On that note I just pulled down the most recent version of request and integrated it into my code and ran my unit tests on it. I'm using request in https://github.com/celer/hopjs to drive the client side test framework and to drive the client side command line tools - hopjs is constructing complex forms and running tests on them - so this is a very good way to test form handling in request / form-data etc.

Prior to the fix you just committed (2.12.0):

caching:
         Pass 53 Fail 0 100.00%
ex3:
         Pass 3 Fail 0 100.00%
files:
         Pass 3 Fail 0 100.00%
interface:
         Pass 6 Fail 0 100.00%
intro:
         Pass 18 Fail 0 100.00%
model:
         Pass 24 Fail 0 100.00%
secure:
         Pass 4 Fail 0 100.00%
test:
         Pass 15 Fail 16 48.39%

After the fix you just committed using the code from request/ HEAD (2.12.1):

caching:
         Pass 53 Fail 0 100.00%
ex3:
         Pass 3 Fail 0 100.00%
files:
         Pass 3 Fail 0 100.00%
interface:
         Pass 6 Fail 0 100.00%
intro:
         Pass 18 Fail 0 100.00%
model:
         Pass 24 Fail 0 100.00%
secure:
         Pass 4 Fail 0 100.00%
test:
         Pass 31 Fail 0 100.00%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment