if query params are empty, then request path shouldn't end with a '?' (merges cleanly now) #462

merged 1 commit into from Mar 4, 2013


None yet

2 participants


If you do this:

req = request.get({ uri: 'http://www.google.com', qs: {}})`

Then req.path equates to /?, which only makes sense if there are some query parameters.

Opening a new PR since issue #436 wasn't merging cleanly.

@mikeal mikeal merged commit 1bb627e into request:master Mar 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment