Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicitly empty user field for basic authentication. #536

Merged
merged 1 commit into from Apr 29, 2013

Conversation

Projects
None yet
2 participants
@mikeando
Copy link
Contributor

commented Apr 29, 2013

The heroku api expects an empty username for authentication. request works OK if you provide that via a "username" field in the auth options, however it raises an exception if you provide an empty "user" field. Simply checking to see if the "user" field is the empty string avoids this.

mikeal added a commit that referenced this pull request Apr 29, 2013

Merge pull request #536 from mikeando/master
Allow explicitly empty user field for basic authentication.

@mikeal mikeal merged commit 6d6b5da into request:master Apr 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.