use agentOptions to create agent when specified in request #568

Merged
merged 2 commits into from Jun 4, 2013

Projects

None yet

2 participants

@SamPlacette
Contributor

Hi,

This changeset includes the changes we discussed in #566 regarding agentOptions, now with some basic tests.

Thanks
Sam

@SamPlacette
Owner

I removed the conditional which would short circuit processing of agentOptions if no poolKey was generated for said agentOptions. This early return was undesirable in cases where agentOptions were specified which did not manifest in the poolKey.

@SamPlacette
Owner

I added ciphers and secureOptions to the poolKey. The poolKey is still by no means exhaustive, but this change better supports these common options now. A better solution might be to simply serialize the agentOptions object and use that as the key, but that would be a larger change and might change existing behavior.

@mikeal mikeal merged commit 24031e9 into request:master Jun 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment