Global cookie jar disabled by default #587

Merged
merged 1 commit into from Jul 5, 2013

Projects

None yet

3 participants

@threepointone
Contributor

As per #571, it's dangerous for the global cookie jar to be on by default. This commit disables that behaviour. To use the global cookie jar, use jar:true.

I think I've got this right, but I'd appreciate a code review.

Thanks!

@mikeal mikeal merged commit 8598f64 into request:master Jul 5, 2013
@luccastera

this makes me happy ๐Ÿ‘

Contributor

cheers mate

@c089 c089 added a commit to c089/rendr that referenced this pull request Dec 30, 2013
@c089 c089 update request to ~2.30.0
this will disable the global cookie jar (see request/request#587)
33ab116
@c089 c089 referenced this pull request in rendrjs/rendr Dec 30, 2013
Merged

update request to ~2.30.0 #248

@nandy-andy nandy-andy pushed a commit to nandy-andy/nodemw that referenced this pull request Mar 21, 2014
@kcivey kcivey reenable cookies in request so login will work again
Cookies are now off by default in the current version of the request module:
request/request#587

As a result, login no longer works. This reenables it.
d5e351d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment