Fixes #583, moved initialization of self.uri.pathname #613

merged 3 commits into from Aug 1, 2013


None yet

2 participants

lexander commented Aug 1, 2013

Moved the initialization of self.uri.pathname up and removed the check for self.uri.pathname being falsey.

Also changed the isUrl regex to handle mixed case properly (e.g. ignore it) and added some test cases for that.

lexander added some commits Jun 30, 2013
@lexander lexander Change isUrl regex to accept mixed case 5cd215f
@lexander lexander #583 added tests for isUrl regex change. 02c8e74
@lexander lexander Moved init of self.uri.pathname
Because the self.uri.pathname var has a default value that is used later in the method, there is no need to check if it is falsey. Just set the pathname to the default if it wasn't set by the user.
@mikeal mikeal merged commit cfd5c9a into request:master Aug 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment