fixes non buffers in data event issue #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncoding manually * added unit test to test/test-body.js * fixed bug by checking if chunk is buffer in main.js * fixes #74
|
i think i see what the problem is. if you setEncoding the chunks won't be buffers, they'll be strings. the code @issacs wrote to merge the array together assumes buffers. it would be lower impact to add this isBuffer check to where it gets concatenated rather than creating new buffers around each chunk if they are already encoded in to a string. |
|
I think I tried what you are suggesting first @mikeal but then the string was being trimmed? Then I thought it oughta be because of the length variable that was being aggregated, so as a simple fix moved it up. |
|
Fixed in a different commit. |
|
@mikeal I think you forgot the test, will help prevent that future improvements re-introduce the bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[main,test-body] fixes non buffers in data event issue when setting encoding manually