Test that browserify works with request. #822

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jchris
Contributor

jchris commented Feb 22, 2014

This test is currently failing. It's kind of brutal because changes in browserify could cause it to fail without any code changes in request. I've tried to capture that by using * in the package.json file.

If there is a more constructive way for me to gripe, let me know!

@mikeal

This comment has been minimized.

Show comment Hide comment
@mikeal

mikeal Feb 23, 2014

Owner

once it's working we can make browserify a dev dependency which would secure a version compatibility.

Owner

mikeal commented Feb 23, 2014

once it's working we can make browserify a dev dependency which would secure a version compatibility.

@jchris

This comment has been minimized.

Show comment Hide comment
@jchris

jchris Feb 23, 2014

Contributor

Except you don't get to control what version a user is using when they
build thier app.

In a perfect world I guess this would be advisory. Eg here are the known
good versions of browserify for this version of request.

I think this is actually a browserify bug but I feel like this used to
work...

On Saturday, February 22, 2014, Mikeal Rogers notifications@github.com
wrote:

once it's working we can make browserify a dev dependency which would
secure a version compatibility.

Reply to this email directly or view it on GitHubhttps://github.com/mikeal/request/pull/822#issuecomment-35819787
.

Chris Anderson
http://jchrisa.net
http://www.couchbase.com

Contributor

jchris commented Feb 23, 2014

Except you don't get to control what version a user is using when they
build thier app.

In a perfect world I guess this would be advisory. Eg here are the known
good versions of browserify for this version of request.

I think this is actually a browserify bug but I feel like this used to
work...

On Saturday, February 22, 2014, Mikeal Rogers notifications@github.com
wrote:

once it's working we can make browserify a dev dependency which would
secure a version compatibility.

Reply to this email directly or view it on GitHubhttps://github.com/mikeal/request/pull/822#issuecomment-35819787
.

Chris Anderson
http://jchrisa.net
http://www.couchbase.com

@mikeal

This comment has been minimized.

Show comment Hide comment
@mikeal

mikeal Aug 27, 2014

Owner

no longer merges cleanly :(

Owner

mikeal commented Aug 27, 2014

no longer merges cleanly :(

@mikeal mikeal closed this Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment