add option followAllRedirects to follow post/put redirects #90

merged 4 commits into from Feb 4, 2012


None yet

4 participants


This should close #55.

request member

this looks good but it's a big change that i want to spend some time reviewing.

i will get to it, i promise, just be patient :)


You have a small letter at followAllredirects, should be:

self.followAllRedirects = (self.followAllRedirects !== undefined) ? self.followAllRedirects : false;

Sure you've gotta lot of stuff on your plate @mikeal, any chance you have some time to revisit this pull request? This would be very helpful to have.

request member

Sorry, forgot all about this one.

This needs a test for maxRedirects added and a line added to the docs to describe the option. Once those are in and the comment by @kitek is addressed it could be merged.

@stolsma stolsma added a commit to stolsma/request that referenced this pull request Dec 11, 2011
@stolsma stolsma [Enhancement] Make redirects with status code 303 change the method t…
…o 'GET'

This behavior is as described by RFC 2616. This change is in addition to issue #55 and issue #90 (pull request)

Ok, took care of the comments raised in this pull request.

  • @kitek's comment has now been addressed.
  • 2 months of changes merged in
  • line added to docs to describe option

Not sure why the maxRedirects test is required for acceptance, it wasn't added in this request. Should we create a new pull request for that issue?

@mikeal mikeal merged commit 00105c2 into request:master Feb 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment