Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

add option followAllRedirects to follow post/put redirects #90

Merged
merged 4 commits into from

4 participants

@jroes

This should close #55.

@mikeal
Owner

this looks good but it's a big change that i want to spend some time reviewing.

i will get to it, i promise, just be patient :)

@kitek

You have a small letter at followAllredirects, should be:

self.followAllRedirects = (self.followAllRedirects !== undefined) ? self.followAllRedirects : false;
@wavded

Sure you've gotta lot of stuff on your plate @mikeal, any chance you have some time to revisit this pull request? This would be very helpful to have.

@mikeal
Owner

Sorry, forgot all about this one.

This needs a test for maxRedirects added and a line added to the docs to describe the option. Once those are in and the comment by @kitek is addressed it could be merged.

@stolsma stolsma referenced this pull request from a commit in stolsma/request
@stolsma stolsma [Enhancement] Make redirects with status code 303 change the method t…
…o 'GET'


This behavior is as described by RFC 2616. This change is in addition to issue #55 and issue #90 (pull request)
2eb1349
@jroes

Ok, took care of the comments raised in this pull request.

  • @kitek's comment has now been addressed.
  • 2 months of changes merged in
  • line added to docs to describe option

Not sure why the maxRedirects test is required for acceptance, it wasn't added in this request. Should we create a new pull request for that issue?

@mikeal mikeal merged commit 00105c2 into request:master
@cybdoom cybdoom referenced this pull request from a commit in cybdoom/EbayAmazonApiServer
@cybdoom cybdoom