Fix various bugs with connection pool handling #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding requests to the queue used wrong parameters. * onCloseOrRemove() didn't remove sockets from the pool. * When using TLS, the pool contained the underlying connection instead of the TLS wrapped connection, causing connections to never be removed. * When a connection was closed and removeSocket() created a new socket to process requests in the queue, the event handlers were not attached to the new socket, causing the new socket to not be removed from the pool when it closed.
mikeal
added a commit
that referenced
this pull request
Apr 18, 2014
Fix various bugs with connection pool handling
|
That is the cause of https://bugs.debian.org/801897 npm 1.4.21 on Debian Jessie is unable to use a proxy. |
wmfgerrit
pushed a commit
to wikimedia/integration-zuul-config
that referenced
this pull request
Dec 22, 2017
npm 1.4.21 from Jessie fails when used behind a proxy:
TypeError: Request path contains unescaped characters
at new ClientRequest (_http_client.js:52:11)
at TunnelingAgent.exports.request (http.js:31:10)
at TunnelingAgent.createSocket (/usr/lib/nodejs/tunnel-agent/index.js:117:25)
That prevent us from bootstrapping npm with:
"/usr/bin/nodejs" "/usr/bin/npm" "install" "-g" "npm@3.8.3"
I have jumped into that rabbit hole previously, basically the npm
version in Jessie does not support HTTP proxy.
Reference:
https://bugs.debian.org/801897 (has patches)
Got fixed in April 2014 via:
request/tunnel-agent#8
This reverts commit 2221c42.
Bug: T177276
Change-Id: Ia18f22f8a081bb9d13eb67d14067161259014744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of the TLS wrapped connection, causing connections to never be
removed.
to process requests in the queue, the event handlers were not attached
to the new socket, causing the new socket to not be removed from the
pool when it closed.