Skip to content

Preventing sending Basic Auth headers with "None:None" #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2015
Merged

Preventing sending Basic Auth headers with "None:None" #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69957cf
Preventing sending Basic Auth headers with "None:None"
chaosct Dec 16, 2015
9b124ef
cleaning code and checking that a password was supplied along username
chaosct Dec 16, 2015
de42424
making operator precedence more readable
chaosct Dec 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion requests_oauthlib/oauth2_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ def fetch_token(self, token_url, code=None, authorization_response=None,
redirect_uri=self.redirect_uri, username=username,
password=password, **kwargs)

auth = auth or requests.auth.HTTPBasicAuth(username, password)
if (not auth) and username:
if password is None:
raise ValueError('Username was supplied, but not password.')
auth = requests.auth.HTTPBasicAuth(username, password)

headers = headers or {
'Accept': 'application/json',
Expand Down