Cleaning the previous token before fetching a new one, to avoid a Tok… #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This seems reasonable to me. =) |
Lukasa
added a commit
that referenced
this pull request
Dec 18, 2015
Cleaning the previous token before fetching a new one, to avoid a Tok…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure the session token gets cleaned before fetching a new one.
The reason is: if I fetch a token from the OAuth2 server, and use the session for more time than the expiration time, and try to fetch a token again, the session will raise a TokenExpiredError. Normally one should use the
refresh_tokenmethod for this purpose, but not all OAuth2 server implementations provide a refresh token endpoint (I'm working with one that doesn't), so it's important to allow the fetching of new tokens without checking the validity of previous ones.