Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Kenneth Reitz
committed
Dec 28, 2011
1 parent
31d495f
commit a91ac24
Showing
1 changed file
with
2 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a91ac24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put such changes to HISTORY.rst or to upgrade guide? This change broke things because positional arguments are not longer supported for requests.request calls after this change.
a91ac24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmike, I've documented and suggested before that all arguments other than
url
and the like are to be treated as positional.I'll add it to the HISTORY next time :)
a91ac24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kennethreitz, thank you, I missed this!