Permalink
Browse files

what is wrong with you people? :)

  • Loading branch information...
1 parent 2b23d6a commit c6084704ccb5610ea093b6b47fb45d2149570174 @kennethreitz kennethreitz committed Jan 31, 2014
Showing with 1 addition and 2 deletions.
  1. +1 −2 requests/models.py
View
@@ -612,8 +612,7 @@ def generate():
try:
# Special case for urllib3.
try:
- for chunk in self.raw.stream(chunk_size,
- decode_content=True):
+ for chunk in self.raw.stream(chunk_size, decode_content=True):
yield chunk
except IncompleteRead as e:
raise ChunkedEncodingError(e)

6 comments on commit c608470

Owner

sigmavirus24 replied Jan 31, 2014

lol if you pep8. ;)

Owner

Lukasa replied Jan 31, 2014

That's me again. =(

😆 , @kennethreitz really doesnt like dirty code.

Contributor

schlamar replied Feb 11, 2014

What's wrong with max line length 80? Would have done the same thing...

You should have a code style documentation if you are strictly opposed to some PEP8 guidelines.

Especially I find this really ugly compared to the original version:

gen = self.resolve_redirects(r, request,
    stream=stream,
    timeout=timeout,
    verify=verify,
    cert=cert,
    proxies=proxies)

Plus this violates PEP8 (E128, continuation line under-indented).

PEP8 conform alternative would be

gen = self.resolve_redirects(
    r, request,
    stream=stream,
    timeout=timeout,
    verify=verify,
    cert=cert,
    proxies=proxies)
Contributor

schlamar replied Feb 11, 2014

BTW, this is from c042c08.

Owner

sigmavirus24 replied Feb 12, 2014

@schlamar arguing style is not worth anyone's time.

Please sign in to comment.