New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestException should subclass IOError #1532

Closed
beck opened this Issue Aug 14, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@beck

beck commented Aug 14, 2013

RuntimeError should only be raised if does not fall in any other categories.

Using urllib as reference, I believe IOError is appropriate.

Related: #419

beck added a commit to yola/demands that referenced this issue Aug 14, 2013

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Aug 15, 2013

Member

Yeah, I think you're right. @kennethreitz, are you open to me doing this for 2.0?

Member

Lukasa commented Aug 15, 2013

Yeah, I think you're right. @kennethreitz, are you open to me doing this for 2.0?

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Aug 15, 2013

Member

yes, especially if IOError subclasses RuntimeError

Member

kennethreitz commented Aug 15, 2013

yes, especially if IOError subclasses RuntimeError

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Aug 15, 2013

Member

IOError is a subclass of EnvironmentError, sadly, not RuntimeError. It'll definitely be backwards incompatible, but I think that's probably acceptable.

Member

Lukasa commented Aug 15, 2013

IOError is a subclass of EnvironmentError, sadly, not RuntimeError. It'll definitely be backwards incompatible, but I think that's probably acceptable.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Aug 15, 2013

Member

could use multiple inheritence

Member

kennethreitz commented Aug 15, 2013

could use multiple inheritence

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Aug 15, 2013

Member

I'm not sure that we'd be fixing the issue in that case. =D We can do it, but we're also at a stage where we can break stuff. I doubt anyone is doing except RuntimeError anyway, so we're probably pretty safe.

Member

Lukasa commented Aug 15, 2013

I'm not sure that we'd be fixing the issue in that case. =D We can do it, but we're also at a stage where we can break stuff. I doubt anyone is doing except RuntimeError anyway, so we're probably pretty safe.

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Aug 27, 2013

Member

Implemented in #1536.

Member

Lukasa commented Aug 27, 2013

Implemented in #1536.

@Lukasa Lukasa closed this Aug 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment