Feature any http verb in docs #482

Closed
kennethreitz opened this Issue Mar 13, 2012 · 10 comments

Comments

Projects
None yet
7 participants
@kennethreitz
Member

kennethreitz commented Mar 13, 2012

No description provided.

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Mar 15, 2012

Member

As @kennethreitz knows, I'm preparing to use requests in a different project, and was testing out the GitHub API. The following is something I did from the python command line interpreter:

import requests
a = ('sigmavirus24', 'not_my_real_password')
url = 'https://api.github.com/repos/sigmavirus24/issues.py/issues/comments/4524692'  # This no longer exists, you'll see why
data = u'{"body": "Amend comment."}'
r = requests.patch(url, data, auth=a)
# Checked what GitHub returned (response code 200)
r = requests.request('DELETE', url, auth=a)
# GitHub responded with code 204 -- successful deletion of a comment on an issue.
Member

sigmavirus24 commented Mar 15, 2012

As @kennethreitz knows, I'm preparing to use requests in a different project, and was testing out the GitHub API. The following is something I did from the python command line interpreter:

import requests
a = ('sigmavirus24', 'not_my_real_password')
url = 'https://api.github.com/repos/sigmavirus24/issues.py/issues/comments/4524692'  # This no longer exists, you'll see why
data = u'{"body": "Amend comment."}'
r = requests.patch(url, data, auth=a)
# Checked what GitHub returned (response code 200)
r = requests.request('DELETE', url, auth=a)
# GitHub responded with code 204 -- successful deletion of a comment on an issue.
@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa May 17, 2012

Member

@kennethreitz: Whereabouts in the docs did you want these? The only place that currently exists that looks suitable is docs/quickstart.rst, but that document is getting increasingly large. Should we consider busting the verbs out into a new file? Or are you happy to extend the quickstart? Either way, I'm happy to write these and add them into #619.

Member

Lukasa commented May 17, 2012

@kennethreitz: Whereabouts in the docs did you want these? The only place that currently exists that looks suitable is docs/quickstart.rst, but that document is getting increasingly large. Should we consider busting the verbs out into a new file? Or are you happy to extend the quickstart? Either way, I'm happy to write these and add them into #619.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz May 17, 2012

Member

Probably in the "advanced" section

Member

kennethreitz commented May 17, 2012

Probably in the "advanced" section

@wulien

This comment has been minimized.

Show comment
Hide comment
@wulien

wulien Dec 11, 2012

I love requests so much, thanks for your excellent work!

wulien commented Dec 11, 2012

I love requests so much, thanks for your excellent work!

@J-Delgado

This comment has been minimized.

Show comment
Hide comment
@J-Delgado

J-Delgado Oct 26, 2013

Sounds great! I'll get right on it!

Sounds great! I'll get right on it!

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Oct 27, 2013

Member

@Fighter42 I don't know why you commented 11 times but this is already taken care of here

Member

sigmavirus24 commented Oct 27, 2013

@Fighter42 I don't know why you commented 11 times but this is already taken care of here

@RAINCEN

This comment has been minimized.

Show comment
Hide comment
@RAINCEN

RAINCEN Nov 20, 2013

I feed my cat!

RAINCEN commented Nov 20, 2013

I feed my cat!

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Nov 20, 2013

Member

@RAINCEN Really? Really?

Member

Lukasa commented Nov 20, 2013

@RAINCEN Really? Really?

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Nov 20, 2013

Member

@Lukasa the emails I received from @RAINCEN had the same message that @Fighter42 posted about 20 times (of which I deleted all but one). I have to wonder if these are just spam accounts or if perhaps this is related to recent attempts to brute force passwords on accounts. Regardless, it's probably advisable to just ignore everyone who makes similar comments on this issue. It's been closed for so long.

Member

sigmavirus24 commented Nov 20, 2013

@Lukasa the emails I received from @RAINCEN had the same message that @Fighter42 posted about 20 times (of which I deleted all but one). I have to wonder if these are just spam accounts or if perhaps this is related to recent attempts to brute force passwords on accounts. Regardless, it's probably advisable to just ignore everyone who makes similar comments on this issue. It's been closed for so long.

@markthink

This comment has been minimized.

Show comment
Hide comment
@markthink

markthink Jun 26, 2014

github great

github great

@requests requests locked and limited conversation to collaborators Jun 26, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.