Fix for the issue https://github.com/kennethreitz/requests/issues/1280 #1281

Merged
merged 1 commit into from Apr 2, 2013

Conversation

Projects
None yet
4 participants
@KamilSzot
Contributor

KamilSzot commented Apr 2, 2013

kennethreitz added a commit that referenced this pull request Apr 2, 2013

@kennethreitz kennethreitz merged commit cdb7007 into requests:master Apr 2, 2013

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
Member

kennethreitz commented Apr 2, 2013

🤘

@@ -339,6 +340,9 @@ def request(self, method, url,
req.cookies = cookies
req.hooks = hooks
+ if not return_response:
+ return req
+

This comment has been minimized.

@t-8ch

t-8ch Apr 2, 2013

Contributor

Those are tabs.

@t-8ch

t-8ch Apr 2, 2013

Contributor

Those are tabs.

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Apr 2, 2013

Member

@kennethreitz why reintroduce this behaviour? It was a documentation mistake on my part.

Member

sigmavirus24 commented Apr 2, 2013

@kennethreitz why reintroduce this behaviour? It was a documentation mistake on my part.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Apr 2, 2013

Member

Woah why did you open this?

Member

kennethreitz commented Apr 2, 2013

Woah why did you open this?

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Apr 2, 2013

Member

Oh, you guys have the same avatar. :(

Member

kennethreitz commented Apr 2, 2013

Oh, you guys have the same avatar. :(

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Apr 2, 2013

Member

Reverted.

Member

kennethreitz commented Apr 2, 2013

Reverted.

@KamilSzot

This comment has been minimized.

Show comment
Hide comment
@KamilSzot

KamilSzot Apr 2, 2013

Contributor

So you won't reintroduce this behavior? Could you suggest what should I do instead to achieve same thing?

Contributor

KamilSzot commented Apr 2, 2013

So you won't reintroduce this behavior? Could you suggest what should I do instead to achieve same thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment