New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the "im_used" informational status code for the value given by IANA (226) #1456

Merged
merged 2 commits into from Jul 15, 2013

Conversation

Projects
None yet
3 participants
@phndiaye
Contributor

phndiaye commented Jul 13, 2013

Changed the "im_used" informational status code for the value given by IANA (226)

See RFC 3229 at http://tools.ietf.org/html/rfc3229#section-10.4.1 and HTTP status codes at http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Jul 13, 2013

Member

@phndiaye Awesome, thanks for this! While we're here, do you want to fix up 208? It should be "already_reported".

Member

Lukasa commented Jul 13, 2013

@phndiaye Awesome, thanks for this! While we're here, do you want to fix up 208? It should be "already_reported".

@phndiaye

This comment has been minimized.

Show comment
Hide comment
@phndiaye

phndiaye Jul 13, 2013

Contributor

Done. By the way, i've seen some status codes that did not match with the ones in the IANA list, but i don't if @kennethreitz did that intentionnaly or if it's just some errors.

Eg:

uri_too_long is set to 122 in requests but the IANA set it to 414 (103 to 199 are unassigned)

Contributor

phndiaye commented Jul 13, 2013

Done. By the way, i've seen some status codes that did not match with the ones in the IANA list, but i don't if @kennethreitz did that intentionnaly or if it's just some errors.

Eg:

uri_too_long is set to 122 in requests but the IANA set it to 414 (103 to 199 are unassigned)

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Jul 13, 2013

Member

Some are intentional, some are errors. uri_too_long looks like it's wrong to me. =)

Member

Lukasa commented Jul 13, 2013

Some are intentional, some are errors. uri_too_long looks like it's wrong to me. =)

@phndiaye

This comment has been minimized.

Show comment
Hide comment
@phndiaye

phndiaye Jul 13, 2013

Contributor

That's what i thought too :). I will be searching for some status like the uri_too_long and do a "global" commit of the corrections.

Contributor

phndiaye commented Jul 13, 2013

That's what i thought too :). I will be searching for some status like the uri_too_long and do a "global" commit of the corrections.

kennethreitz added a commit that referenced this pull request Jul 15, 2013

Merge pull request #1456 from phndiaye/master
Changed the "im_used" informational status code for the value given by IANA (226)

@kennethreitz kennethreitz merged commit de9d844 into requests:master Jul 15, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment