New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Proxy urls should have explicit schemes. #1497

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Lukasa
Member

Lukasa commented Jul 28, 2013

This is for 2.0, and is in response to @t-8ch's suggestion that proxies should have explicit schemes instead of guessing (which is stupid).

@sigmavirus24, @kennethreitz: I'm not entirely happy with the validation code being here: let me know if you have a better idea for where it should go.

@t-8ch

This comment has been minimized.

Show comment
Hide comment
@t-8ch

t-8ch Jul 28, 2013

Contributor

I recently checked was curl is doing with different proxy schemes.
Curl ignores the scheme and always connects to the proxy using plain http.
What curl does support, what could be nice to have are CONNECT tunnels for plain http, if the proxy is messing things up.

Contributor

t-8ch commented Jul 28, 2013

I recently checked was curl is doing with different proxy schemes.
Curl ignores the scheme and always connects to the proxy using plain http.
What curl does support, what could be nice to have are CONNECT tunnels for plain http, if the proxy is messing things up.

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Jul 28, 2013

Member

Shorter stacktraces == easier to read exceptions for most users. If we can do the validation when someone sets Session.proxies or passes the proxies parameter that would be awesome. The lowest they would then see would be Session.request which isn't all too horrible all things considered.

Member

sigmavirus24 commented Jul 28, 2013

Shorter stacktraces == easier to read exceptions for most users. If we can do the validation when someone sets Session.proxies or passes the proxies parameter that would be awesome. The lowest they would then see would be Session.request which isn't all too horrible all things considered.

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Jul 29, 2013

Member

@sigmavirus24 Yeah, I thought about that. Unfortunately, users can send directly into a Transport Adapter (it's a supported flow), and if they did that then they would lose this validation.

Member

Lukasa commented Jul 29, 2013

@sigmavirus24 Yeah, I thought about that. Unfortunately, users can send directly into a Transport Adapter (it's a supported flow), and if they did that then they would lose this validation.

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Jul 29, 2013

Member

Ah good call. This is an obvious 👍 then.

Member

sigmavirus24 commented Jul 29, 2013

Ah good call. This is an obvious 👍 then.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Aug 1, 2013

Member

Closing since this is merged into #1509

Member

kennethreitz commented Aug 1, 2013

Closing since this is merged into #1509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment