Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

URI cleanup of non-path components #431

Merged
merged 4 commits into from Feb 15, 2012

Conversation

Projects
None yet
2 participants
Contributor

mgiuca commented Feb 15, 2012

My previous branch fixed URI cleanup for path components. This branch extends that fix to address Issue #429, which requires URI cleanup for the query part of the URI.

I have added comprehensive tests for the sanitisation of the query part of the URI, and rearranged the call to utils.requote_path so that it is now applied to the whole URI after it is constructed, and not just the path. Note that this required that all URI components be converted to UTF-8 before the URI is reconstructed (since the URI is now sanitised after reconstruction). I have renamed utils.requote_path to requote_uri to reflect its new role.

Owner

kennethreitz commented Feb 15, 2012

This is fantastic. Thanks a ton. I really appreciate this.

Owner

kennethreitz commented Feb 15, 2012

🍰

@kennethreitz kennethreitz merged commit 690426a into requests:develop Feb 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment