Fix infinite loop on wrong Digest Authentication #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #298 (File upload not working with HTTP digest authentication)
|
Hmm, the second commit is something different (I should have created a branch). I am less convinced that my implementation is the right way to do it there, so take it as a suggestion (and motivation to fix a 4 months old bug hit by one of our clients :p). |
|
This is fantastic. Thanks! 🍰 |
vickimo
pushed a commit
to vickimo/requests
that referenced
this pull request
Jul 14, 2012
Modified code to use the current fix versus the old fix, which was broken. Co-Authored By: Timnit Gebru <tgebru@gmail.com> Co-Authored By: Sarah Gonzalez <smar.gonz@gmail.com> Co-Authored By: Leila Muhtasib <muhtasib@gmail.com>
exvito
added a commit
to exvito/requests
that referenced
this pull request
Apr 2, 2015
The existing code counts the number of 401 responses in the num_401_calls authenticator attribute. This is in place so as to ensure the necessary auth header is sent, while avoiding infinite 401 loops (issue psf#547). This commit makes num_401_calls an instance of threading.local() (previously an integer), using num_401_calls.value as the counter. It ensures that concurrent authentication requests get each their own counter and behave as expected (otherwise every other concurrent request would have its authentication fail).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most straightforward way to fix #541 seems to be to deregister the hook on the first 401. This is what I have implemented here.