Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and test for #458 #580

Merged
merged 2 commits into from May 4, 2012
Merged

Fix and test for #458 #580

merged 2 commits into from May 4, 2012

Conversation

slingamn
Copy link
Contributor

@slingamn slingamn commented May 4, 2012

Fix and test for #458.

@travisbot
Copy link

This pull request passes (merged 35ec6bb into 317f64a).

@slingamn
Copy link
Contributor Author

slingamn commented May 4, 2012

Heh, if the user sets headers={'connection': 'keep-alive'} and config={'keep_alive': False}, which should win? Right now it's the config.

@kennethreitz
Copy link
Contributor

You're amazing.

kennethreitz pushed a commit that referenced this pull request May 4, 2012
Merge pull request #580 from slingamn/keepalive
1adaba3 
Fix and test for #458
@kennethreitz kennethreitz merged commit 1adaba3 into psf:develop May 4, 2012
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slingamn @travisbot @kennethreitz