New implementation of safe_mode. #604

Merged
merged 2 commits into from May 10, 2012

Conversation

Projects
None yet
3 participants
Contributor

joshimhoff commented May 10, 2012

We throw exceptions in models.py even if in safe_mode. We catch those exceptions at the API level and return a blank Response with the error field filled with the exception thrown. See safe_mode.py for details.

Discussed here: #583

joshimhoff added some commits May 9, 2012

New implementation of safe_mode. Now, we throw exceptions in models.p…
…y regardless of safe_mode. We catch those exceptions at the API level and return a blank Response. See safe_mode.py for details.

This pull request passes (merged cff70e7 into 2d328d8).

This pull request passes (merged db43eb4 into 2d328d8).

Owner

kennethreitz commented May 10, 2012

Fantastic work! This is much cleaner.

🍰

kennethreitz added a commit that referenced this pull request May 10, 2012

Merge pull request #604 from joshimhoff/develop
New implementation of safe_mode.

@kennethreitz kennethreitz merged commit 3d2d072 into requests:develop May 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment