Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make external relative paths working again #38

merged 1 commit into from Sep 6, 2012


None yet
2 participants

kondi commented Sep 5, 2012

You can not depend currently on a relative module using too many parent notation.

For example:
define("something", ["../../dependency"], ...);

The related iteration was replaced by an each call in commit c9657f2 which was reverted later in commit ce262cf. In first commit the break statement was rewritten to return true but in the latter it is not reverted to break.

Pull Request:

The bug is fixed and the relativePaths test suite is updated to test the problematic case.


kondi commented Sep 5, 2012

Please do not care about "The Travis build failed" message, CI is not configured yet correctly.

jrburke added a commit that referenced this pull request Sep 6, 2012

Merge pull request #38 from kondi/master
Make external relative paths working again

@jrburke jrburke merged commit 11630b2 into requirejs:master Sep 6, 2012


jrburke commented Sep 6, 2012

Thank you very much for catching that silly mistake, and thank you even more for the test case! I did a 0.1.4 release, the only change over 0.1.3 is this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment