2.0 r.js quits unexpectedly for plugin builds #181

Closed
guybedford opened this Issue Jun 1, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@guybedford

This may be related to #175.

I am using the require-jade plugin (https://github.com/rocketlabsdev/require-jade).

Before upgrading, the builds were working fine. Since upgrading, any build config which includes a dependency loaded through this plugin breaks the optimize function.

I also have an identical issue with my own plugin, with or without a pluginBuilder method.

@jrburke

This comment has been minimized.

Show comment Hide comment
@jrburke

jrburke Jun 1, 2012

Owner

Right, I think it is a combination of #175 and #179 not throwing if error logging is turned off. You can try the latest master r.js to see if you now get an error (#179), so that we can determine if #175 is the root cause. I should also have #175 fixed today too, planning a 2.0.1 release today.

Owner

jrburke commented Jun 1, 2012

Right, I think it is a combination of #175 and #179 not throwing if error logging is turned off. You can try the latest master r.js to see if you now get an error (#179), so that we can determine if #175 is the root cause. I should also have #175 fixed today too, planning a 2.0.1 release today.

@jrburke

This comment has been minimized.

Show comment Hide comment
@jrburke

jrburke Jun 1, 2012

Owner

I just tried the jade plugin, and I get a 'use strict' violation when using it, which is a new bug, so I'll use this bug to track that issue.

Owner

jrburke commented Jun 1, 2012

I just tried the jade plugin, and I get a 'use strict' violation when using it, which is a new bug, so I'll use this bug to track that issue.

@jrburke jrburke closed this in 334d823 Jun 1, 2012

@guybedford

This comment has been minimized.

Show comment Hide comment
@guybedford

guybedford Jun 1, 2012

Perfect, thank you so much! This has fixed the issue entirely.

I did not get any further error messages or issues after updating r.js.

Perfect, thank you so much! This has fixed the issue entirely.

I did not get any further error messages or issues after updating r.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment