New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esprima to 4.0 #963

Closed
marcoscaceres opened this Issue Jul 19, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@marcoscaceres

marcoscaceres commented Jul 19, 2017

I wonder if it might be possible, as a first step towards #959 to update Esprima in r.js?

Totally guessing here, but given that you can already tell r.js not to Uglify, then one can run Uglify-es separately without r.js crashing on ES6 code?

@jrburke jrburke added this to the 2.3.4 milestone Jul 20, 2017

@jrburke jrburke closed this in d689d89 Jul 20, 2017

@jrburke

This comment has been minimized.

Show comment
Hide comment
@jrburke

jrburke Jul 20, 2017

Member

I ran out of time tonight to release a tagged version of 2.3.4 with this change, but this master snapshot can be used for now:
https://raw.githubusercontent.com/requirejs/r.js/master/dist/r.js

and I should get the tagged release out before next week, ideally tomorrow.

Member

jrburke commented Jul 20, 2017

I ran out of time tonight to release a tagged version of 2.3.4 with this change, but this master snapshot can be used for now:
https://raw.githubusercontent.com/requirejs/r.js/master/dist/r.js

and I should get the tagged release out before next week, ideally tomorrow.

@marcoscaceres

This comment has been minimized.

Show comment
Hide comment
@marcoscaceres

marcoscaceres Jul 21, 2017

Ha! It totally works 💃🕺 I just set "optimize" to "none" and then manually ran the code through Uglyfy-ES. So excited about this, @jrburke! Can't wait for it to hit RequireJS upstream now.

marcoscaceres commented Jul 21, 2017

Ha! It totally works 💃🕺 I just set "optimize" to "none" and then manually ran the code through Uglyfy-ES. So excited about this, @jrburke! Can't wait for it to hit RequireJS upstream now.

@jrburke

This comment has been minimized.

Show comment
Hide comment
@jrburke

jrburke Jul 21, 2017

Member

Just published requirejs 2.3.4 with this fix.

Member

jrburke commented Jul 21, 2017

Just published requirejs 2.3.4 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment