Fix building multiple modules with shared excludes #322

Merged
merged 2 commits into from Mar 3, 2013

Projects

None yet

2 participants

@avaly
Contributor
avaly commented Nov 24, 2012

If module A & B both require module Z but also are set to exclude it,
after build, A & B don't contain Z as expected,
but module Z is empty.

@avaly avaly Fix building multiple modules with shared excludes
If module A & B both require module Z but also are set to exclude it,
after build, A & B don't contain Z as expected,
but module Z is empty.
2b18847
@avaly
Contributor
avaly commented Nov 24, 2012

Sorry, but I didn't have time to write up a test for this. I'll try to find some time next week, if nobody does that before.

@jrburke
Member
jrburke commented Nov 30, 2012

A test case would be useful. I'm not sure what situation is failing. At the very least perhaps a build config that shows the problem, and describing what is missing from the build output.

@avaly
Contributor
avaly commented Jan 23, 2013

Seems like this pull missed the 2.1.3 version. Hope it will get merged for 2.1.4!

@jrburke
Member
jrburke commented Jan 24, 2013

Sorry, I did not get notified of the tests added, so I did not assign this to a milestone. Putting it this in the 2.1.5 milestone for consideration -- I have to do a quickfix 2.1.4 release for something in 2.1.3 that broke.

@jrburke jrburke merged commit 3bfaffb into requirejs:master Mar 3, 2013
@jrburke
Member
jrburke commented Mar 3, 2013

Merged, thank you! The unit test was awesome to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment