Fix the syntax error on declaration of `addFile()` #929

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@janza
janza commented Sep 5, 2016

Fixes #928

@jquerybot

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@jrburke
Member
jrburke commented Sep 5, 2016

Looks like it is old 0.10 and 0.12 versions of node that report this problem, versions 4-6 report to be fine, according to reports in requirejs/requirejs#1583

I will use this ticket to track the final fix. I'll want to do a bit more than what is done in this pull request since this js file is generated by a script, but I should have a fix up within the day.

@jrburke jrburke added this to the 2.3.1 milestone Sep 5, 2016
@jrburke jrburke closed this in 59a9c8c Sep 5, 2016
@jrburke
Member
jrburke commented Sep 5, 2016

Thank you for the fix. I committed a change that does the equivalent in the script that generates that file. Version 2.3.1 has been released with the fix now.

@janza
janza commented Sep 5, 2016

Great, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment