Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra function call #69

Merged
merged 1 commit into from Mar 19, 2015
Merged

Remove extra function call #69

merged 1 commit into from Mar 19, 2015

Conversation

just-boris
Copy link
Contributor

There is no need to call require again since the core module do it itself here: https://github.com/jrburke/requirejs/blob/master/require.js#L1074

I've tested on demo and demo-build showcases and want to use it in my project.

@kumarharsh
Copy link
Member

Thanks @just-boris. I'll have a look and merge it probably over the weekend

@just-boris
Copy link
Contributor Author

@kumarharsh any news?

@kumarharsh
Copy link
Member

@just-boris am on a vacation for a few more days... will take a look when I return.

Regards
Harsh

@kumarharsh
Copy link
Member

seems like that line was there from the first commit...

kumarharsh pushed a commit that referenced this pull request Mar 19, 2015
Remove extra function call
@kumarharsh kumarharsh merged commit 842e8b8 into requirejs:master Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants