New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.11 => 2.1.12 build bug #1129

Closed
leobalter opened this Issue May 27, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@leobalter

leobalter commented May 27, 2014

I've found a build bug on 2.1.12 when trying to run jquery/globalize tests

You can check this here:

Note that grunt-contrib-requirejs searchs for ~2.1.0, so 2.1.12 is comming on all further npm installs till a new version release.

I did all the diffs to find what was happening and the only practical diff that have interference with this build was this require version, that adds an extra . on namespaced methods.

JSHint exploded on that, e.g.:

Running "jshint:dist" (jshint) task
Linting dist/globalize/date.js ...ERROR
[L35:C9] W033: Missing semicolon.
var date..ArrayMap = function( array, callback ) {
[L35:C9] E030: Expected an identifier and instead saw '.'.
var date..ArrayMap = function( array, callback ) {
[L35:C10] E033: Expected an operator and instead saw '.'.
...

To double check if the problem was on requirejs, I've went to node_modules/grunt-contrib-requirejs folder (on Globalize project), and manually installed RequireJS 2.1.11 with npm install requirejs@2.1.11. Then the globalize build worked fine.

I'll fork/download this repo to try to help and submit a PR, till there, I think it is enough reported. :)

Cheers

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter May 27, 2014

Ok, found that this came out on @3f9160e, that fixed #1107, exactly here

A rollback would fix other projects - as Globalize - but reopen #1107 issue, I would go for it, but it's up to your decision now.

cc: @jzaefferer, @rxaviers

leobalter commented May 27, 2014

Ok, found that this came out on @3f9160e, that fixed #1107, exactly here

A rollback would fix other projects - as Globalize - but reopen #1107 issue, I would go for it, but it's up to your decision now.

cc: @jzaefferer, @rxaviers

leobalter added a commit to leobalter/requirejs that referenced this issue May 27, 2014

@jrburke jrburke added this to the 2.1.13 milestone May 27, 2014

@jrburke jrburke closed this in c5e93ca May 27, 2014

@jrburke

This comment has been minimized.

Show comment
Hide comment
@jrburke

jrburke May 27, 2014

Member

Thanks for pointing this out. Sorry for the messing that up. I just pushed a fix, and will push out a 2.1.13 shortly. Going with a fix instead of a rollback to maintain the other fixes. Tested locally in globalize and it passes with this change.

Member

jrburke commented May 27, 2014

Thanks for pointing this out. Sorry for the messing that up. I just pushed a fix, and will push out a 2.1.13 shortly. Going with a fix instead of a rollback to maintain the other fixes. Tested locally in globalize and it passes with this change.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter May 27, 2014

Perfect. Thank you

leobalter commented May 27, 2014

Perfect. Thank you

jrburke added a commit to requirejs/r.js that referenced this issue May 27, 2014

@jrburke

This comment has been minimized.

Show comment
Hide comment
@jrburke

jrburke May 27, 2014

Member

2.1.13 is published now.

Member

jrburke commented May 27, 2014

2.1.13 is published now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment