Skip to content

2.1.11 => 2.1.12 build bug  #1129

Closed
Closed
@leobalter

Description

@leobalter

I've found a build bug on 2.1.12 when trying to run jquery/globalize tests

You can check this here:

Note that grunt-contrib-requirejs searchs for ~2.1.0, so 2.1.12 is comming on all further npm installs till a new version release.

I did all the diffs to find what was happening and the only practical diff that have interference with this build was this require version, that adds an extra . on namespaced methods.

JSHint exploded on that, e.g.:

Running "jshint:dist" (jshint) task
Linting dist/globalize/date.js ...ERROR
[L35:C9] W033: Missing semicolon.
var date..ArrayMap = function( array, callback ) {
[L35:C9] E030: Expected an identifier and instead saw '.'.
var date..ArrayMap = function( array, callback ) {
[L35:C10] E033: Expected an operator and instead saw '.'.
...

To double check if the problem was on requirejs, I've went to node_modules/grunt-contrib-requirejs folder (on Globalize project), and manually installed RequireJS 2.1.11 with npm install requirejs@2.1.11. Then the globalize build worked fine.

I'll fork/download this repo to try to help and submit a PR, till there, I think it is enough reported. :)

Cheers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions