Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sip2: implements selfcheck user accounts #1754

Merged
merged 1 commit into from Mar 31, 2021
Merged

sip2: implements selfcheck user accounts #1754

merged 1 commit into from Mar 31, 2021

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Mar 5, 2021 •
edited

To easiest manage selfcheck user accounts, we separate them from rero-ils users.

  • Adds separate table to store selfcheck users.
  • Adatps loan json schema to store terminal id on creation.
  • Adds command into Dockerfile to install sip2 module.

Co-Authored-by: Laurent Dubois laurent.dubois@itld-solutions.be

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d self-assigned this Mar 5, 2021
@lauren-d lauren-d added this to New in RERO ILS PRs via automation Mar 5, 2021
@lauren-d lauren-d added this to the v1.2.0 milestone Mar 5, 2021
@lauren-d lauren-d marked this pull request as draft March 5, 2021 22:46
@lauren-d lauren-d force-pushed the lau-#2030-sip2-clients-table branch 12 times, most recently from 5f86a22 to 82dce7e Compare March 8, 2021 16:12
@jma jma modified the milestones: v1.1.0, v1.2.0 Mar 17, 2021
@lauren-d lauren-d force-pushed the lau-#2030-sip2-clients-table branch 6 times, most recently from 705855f to 2991f8f Compare March 18, 2021 23:12
@lauren-d lauren-d added the f: circulation Concerns the circulation interface or backend label Mar 19, 2021
@lauren-d lauren-d marked this pull request as ready for review March 25, 2021 14:01
zannkukai
zannkukai reviewed Mar 25, 2021
View reviewed changes
rero_ils/modules/selfcheck/models.py Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
sebdeleze
sebdeleze approved these changes Mar 29, 2021
View reviewed changes
rero_ils/modules/locations/api.py Outdated Show resolved Hide resolved
rero_ils/modules/locations/api.py Show resolved Hide resolved
rero_ils/modules/selfcheck/permissions.py Outdated Show resolved Hide resolved
tests/api/conftest.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/admin.py Show resolved Hide resolved
@lauren-d lauren-d force-pushed the lau-#2030-sip2-clients-table branch 2 times, most recently from 0f90600 to 04ab4dc Compare March 31, 2021 09:01
@lauren-d lauren-d requested a review from zannkukai March 31, 2021 09:04
@lauren-d lauren-d force-pushed the lau-#2030-sip2-clients-table branch 2 times, most recently from d95c7e8 to 0e0b637 Compare March 31, 2021 11:58
@lauren-d
sip2: implements selfcheck user accounts
9f68ca1 
To easiest manage selfcheck user accounts, we separate them from rero-ils users.

* Adds separate table to store selfcheck users.
* Adatps loan json schema to store terminal id on creation.
* Adds command into Dockerfile to install sip2 module.

Co-Authored-by: Laurent Dubois <laurent.dubois@itld-solutions.be>
@lauren-d lauren-d force-pushed the lau-#2030-sip2-clients-table branch from 0e0b637 to 9f68ca1 Compare March 31, 2021 13:00
@lauren-d lauren-d merged commit 12fda14 into rero:US2014-sip2-implementation-rero Mar 31, 2021
RERO ILS PRs automation moved this from New to Closed PR Mar 31, 2021
@lauren-d lauren-d deleted the lau-#2030-sip2-clients-table branch June 15, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@jma jma Awaiting requested review from jma

@BadrAly BadrAly Awaiting requested review from BadrAly

@rerowep rerowep Awaiting requested review from rerowep

Assignees

@lauren-d lauren-d

Labels
f: circulation Concerns the circulation interface or backend
Projects
No open projects
RERO ILS PRs
  
Closed PR
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lauren-d @sebdeleze @zannkukai @benerken @jma