item: field call number is now optional #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
2 times, most recently
from
7d74f38
to
6807087
Compare
zannkukai
approved these changes
May 3, 2020
iGormilhit
suggested changes
May 4, 2020
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
from
6807087
to
3b17492
Compare
BadrAly
changed the title
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
from
3b17492
to
ab61552
Compare
iGormilhit
approved these changes
May 4, 2020
zannkukai
approved these changes
May 4, 2020
benerken
approved these changes
May 4, 2020
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
3 times, most recently
from
adb78fb
to
ad8cb14
Compare
rerowep
reviewed
May 4, 2020
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
from
ad8cb14
to
3d75c72
Compare
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
from
3d75c72
to
d7acf6a
Compare
rerowep
approved these changes
May 5, 2020
jma
requested changes
May 5, 2020
The item call number is now an optional field in both the item json schema and item editor. This field is not populated if not given by the librarian. The item barcode remains a required field in the item json schema, on the other side, it is an optional field in the item editor. If a librarian decides not to add an item barcode, the system will automatically populate the barcode with the following: f-current timestamp. * Adapts schema, tests and files correspondingly. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com> Co-Authored-by: Aly Badr<aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-item-barcode-call-number
branch
from
d7acf6a
to
7283789
Compare
jma
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The item call number is now an optional field in both the
item json schema and item editor. This field is not populated
if not given by the librarian.
The item barcode remains a required field in the item json schema,
on the other side, it is an optional field in the item editor.
If a librarian decides not to add an item barcode, the system
will automatically populate the barcode with the following:
f-current timestamp.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Co-Authored-by: Aly Badraly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/us/1328?milestone=263424
How to test?
bootstrap+setupin the UI, you should be able to add items without barcodes
Code review check list