From 6394edfd075ff81a34b63a5b3b94c0e24bb85c75 Mon Sep 17 00:00:00 2001
From: Clement Rey <cr.rey.clement@gmail.com>
Date: Fri, 30 Jun 2023 15:18:58 +0200
Subject: [PATCH] Codegen'd Rust/Arrow (de)ser 4: out-of-sync definitions CI
 detection (#2545)

Enables detection of out-of-sync fbs definitions on the CI now that
things are stable enough.

---

- #2484
- #2485
- #2487
- #2545
- #2546
- #2549
- #2554
- #2570
- #2571

---

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2487

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/4200af1/docs
Examples preview: https://rerun.io/preview/4200af1/examples
<!-- pr-link-docs:end -->
---
 crates/re_types/build.rs         | 15 +++++++--------
 crates/re_types/source_hash.txt  |  2 +-
 crates/re_types_builder/build.rs | 15 +++++++--------
 3 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/crates/re_types/build.rs b/crates/re_types/build.rs
index 9137eb464ba4..cc08f5181a0d 100644
--- a/crates/re_types/build.rs
+++ b/crates/re_types/build.rs
@@ -20,14 +20,6 @@ const RUST_OUTPUT_DIR_PATH: &str = ".";
 const PYTHON_OUTPUT_DIR_PATH: &str = "../../rerun_py/rerun_sdk/rerun/_rerun2";
 
 fn main() {
-    if std::env::var("CI").is_ok() {
-        // Don't run on CI!
-        //
-        // The code we're generating here is actual source code that gets committed into the
-        // repository.
-        return;
-    }
-
     if !is_tracked_env_var_set("IS_IN_RERUN_WORKSPACE") {
         // Only run if we are in the rerun workspace, not on users machines.
         return;
@@ -64,6 +56,13 @@ fn main() {
         }
     }
 
+    // Detect desyncs between definitions and generated when running on CI, and
+    // crash the build accordingly.
+    #[allow(clippy::manual_assert)]
+    if std::env::var("CI").is_ok() {
+        panic!("re_types' fbs definitions and generated code are out-of-sync!");
+    }
+
     let sh = Shell::new().unwrap();
 
     re_types_builder::generate_rust_code(
diff --git a/crates/re_types/source_hash.txt b/crates/re_types/source_hash.txt
index 672ccc20c301..076ec5a0f013 100644
--- a/crates/re_types/source_hash.txt
+++ b/crates/re_types/source_hash.txt
@@ -1,4 +1,4 @@
 # This is a sha256 hash for all direct and indirect dependencies of this crate's build script.
 # It can be safely removed at anytime to force the build script to run again.
 # Check out build.rs to see how it's computed.
-c10dc39333002ce5c62d9e88a7feb4fca76098528fe643012a53665a9934581e
\ No newline at end of file
+ffa869371b5fc08da6c80ce53a84db674682b38152c458d958649decc8949f35
\ No newline at end of file
diff --git a/crates/re_types_builder/build.rs b/crates/re_types_builder/build.rs
index bac5e2d4deb6..8d9b613b98c7 100644
--- a/crates/re_types_builder/build.rs
+++ b/crates/re_types_builder/build.rs
@@ -14,14 +14,6 @@ const SOURCE_HASH_PATH: &str = "./source_hash.txt";
 const FBS_REFLECTION_DEFINITION_PATH: &str = "./definitions/reflection.fbs";
 
 fn main() {
-    if std::env::var("CI").is_ok() {
-        // Don't run on CI!
-        //
-        // The code we're generating here is actual source code that gets committed into the
-        // repository.
-        return;
-    }
-
     if !is_tracked_env_var_set("IS_IN_RERUN_WORKSPACE") {
         // Only run if we are in the rerun workspace, not on users machines.
         return;
@@ -54,6 +46,13 @@ fn main() {
         }
     }
 
+    // Detect desyncs between definitions and generated when running on CI, and
+    // crash the build accordingly.
+    #[allow(clippy::manual_assert)]
+    if std::env::var("CI").is_ok() {
+        panic!("re_types_builder's fbs definitions and generated code are out-of-sync!");
+    }
+
     // NOTE: This requires `flatc` to be in $PATH, but only for contributors, not end users.
     // Even for contributors, `flatc` won't be needed unless they edit some of the .fbs files.
     let sh = Shell::new().unwrap();