Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a simple example to use every primitive #1599

Closed
asuper0 opened this issue Mar 16, 2023 · 8 comments
Closed

Need a simple example to use every primitive #1599

asuper0 opened this issue Mar 16, 2023 · 8 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples good first issue Good for newcomers help wanted Extra attention is needed notebook Jupyter notebooks etc

Comments

@asuper0
Copy link

asuper0 commented Mar 16, 2023

Describe the annoyance

The existing examples are too complicated, core function of rerun are flooded with codes for data processing or algorithm. It's hard for me to find out usage of the primitives, especially for the rust language, for the lack of rust example.

Expected behavior

A simple example with very simple data, which shows basic usage of every primitives, in both rust and python.

@asuper0 asuper0 added 👀 needs triage This issue needs to be triaged by the Rerun team 😤 annoying Something in the UI / SDK is annoying to use labels Mar 16, 2023
@jleibs
Copy link
Member

jleibs commented Mar 16, 2023

Agreed. A nicely organized standalone version of each API, linked from the primitives docs is something we’ve been talking about for a while. Will try to get to that soon.

In the mean time the api_demo is probably the closest to what you might be looking for: https://github.com/rerun-io/rerun/blob/latest/examples/rust/api_demo/src/main.rs

Very little algorithm code in there and most of the sub-samples are focused on just one API surface. But not everything is covered or organized perfectly.

@nikolausWest nikolausWest added 📖 documentation Improvements or additions to documentation and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 16, 2023
@asuper0
Copy link
Author

asuper0 commented Mar 17, 2023

That could helps, thank you.
Also expect the one you metioned😁

@emilk
Copy link
Member

emilk commented Mar 20, 2023

@emilk
Copy link
Member

emilk commented Apr 17, 2023

Let's expand on api_demo to include all primitives. Help wanted 🙏

@emilk emilk added good first issue Good for newcomers help wanted Extra attention is needed examples Issues relating to the Rerun examples labels Apr 17, 2023
@jleibs
Copy link
Member

jleibs commented Apr 17, 2023

Now that we have notebook support, I think we should take a stab at using it to document the python APIs. We can maintain the doc- notebooks in the repository, and run them headless in CI using nbconvert. This both tests the APIs work and generates artifacts we can host.

For example

jupyter nbconvert --to=html --ExecutePreprocessor.enabled=True examples/python/notebook/cube.ipynb

Creates a standlone html document:
image

We can also push these same notebooks to colab and link as appropriate so that users can quickly play around with the API samples live if they want to experiment.

@Wumpf
Copy link
Member

Wumpf commented Apr 18, 2023

Agreed, this would be a huge boost for our documentation! One of the best parts of this is that it makes it so much easier for us to write literate-programming-like examples, making the doc maintenance itself easier on us code-focused folks

@emilk
Copy link
Member

emilk commented Apr 18, 2023

This is more user-facing, while we should also have a separate api_test that is completely exhaustive with all different tensor types, etc.

@emilk emilk added the notebook Jupyter notebooks etc label Apr 19, 2023
@emilk
Copy link
Member

emilk commented Jun 12, 2023

Closed in favor of the actionable #2382

@emilk emilk closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples good first issue Good for newcomers help wanted Extra attention is needed notebook Jupyter notebooks etc
Projects
None yet
Development

No branches or pull requests

5 participants