Really fix pnpm this time (#111)

* Really fix pnpm this time

* Beta 3

Author: cknitt

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "create-rescript-app",
-  "version": "1.12.0-beta.2",
+  "version": "1.12.0-beta.3",
   "description": "Quickly create new ReScript apps from project templates.",
   "main": "out/create-rescript-app.cjs",
   "scripts": {

package.json

@@ -17,8 +17,23 @@ let defaultPackagerInfo = {packageManager: Npm, command: "npm"}
 @scope(("process", "env"))
 external npm_execpath: option<string> = "npm_execpath"
 
+@scope(("process", "env"))
+external npm_config_user_agent: option<string> = "npm_config_user_agent"
+
+let isPnpmUserAgent = () =>
+  switch npm_config_user_agent {
+  | Some(userAgent) =>
+    userAgent
+    ->String.toLowerCase
+    ->String.split(" ")
+    ->Array.some(segment => segment->String.startsWith("pnpm/"))
+  | None => false
+  }
+
 let getPackageManagerInfo = async () =>
+  // Note: pnpm does not set npm_execpath
   switch npm_execpath {
+  | None if isPnpmUserAgent() => {packageManager: Pnpm, command: "pnpm"}
   | None => defaultPackagerInfo
   | Some(execPath) =>
     // #58: Windows: packageManager may be something like
@@ -41,7 +56,7 @@ let getPackageManagerInfo = async () =>
       let isYarn1 = CompareVersions.compareVersions(version, "2.0.0")->Ordering.isLess
 
       Some(isYarn1 ? Yarn1 : YarnBerry)
-    | _ if filename->String.includes("pnpm") => Some(Pnpm)
+    | _ if filename->String.includes("pnpm") => Some(Pnpm) // in case pnpm sets npm_execpath in a future version
     | _ if filename->String.includes("npm") => Some(Npm) // make sure this goes after pnpm ...
     | _ if filename->String.includes("bun") => Some(Bun)
     | _ => None

src/PackageManagers.res

@@ -85,7 +85,11 @@ let installVersions = async ({rescriptVersion, rescriptCoreVersion}) => {
 
   switch packageManager {
   | YarnBerry => await ensureYarnNodeModulesLinker()
-  | Pnpm => await execCommand("import") // import versions from package-lock.json
+  | Pnpm =>
+    let hasPackageLock = Path.join2(Process.cwd(), "package-lock.json")->Fs.existsSync
+    if hasPackageLock {
+      await execCommand("import") // import versions from package-lock.json
+    }
   | _ => ()
   }