Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bs.xx -> xx transition, no bs prefix needed #4701

Merged
merged 41 commits into from
Sep 17, 2020
Merged

bs.xx -> xx transition, no bs prefix needed #4701

merged 41 commits into from
Sep 17, 2020

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Sep 16, 2020 •
edited
Loading

Note two attribues are not carried,

  • bs.send.pipe, it still works but send.pipe will not, since this style is deprecated for a long time
  • bs.splice, it is recommended to use variadic

@bobzhang
refactoring
8d539d3
@bobzhang
allow both bs.deriving and deriving
25faa72
@bobzhang
allow bs.config and config
a20f109
@bobzhang
snapshot
69100fd
@bobzhang
tweak
43b4c50
@bobzhang
allow both bs.this and this
d4cd553
@bobzhang
snapshot
5df20b4
@bobzhang
allow both bs.meth and meth
2daa9b1
@bobzhang
snapshot
373d098
@bobzhang
tweak
3ab5f2c
@bobzhang
remove BS_NATIVE_PPX
eea1d3c
@bobzhang
snapshot
0b87b80
@bobzhang
allow bs.as and as
f6bcab8
@bobzhang
snapshot
77a45ba
@bobzhang
allow both bs.ignore and ignore
13f608a
@bobzhang
snapshot
bc53ed6
@bobzhang
bs.string/bs.int + string/int
4b6a1ef
@bobzhang
snapshot
edcff95
@bobzhang
bs.uncurry and bs.unwrap transition
c974964
@bobzhang
snapshot
64c7379
@bobzhang
tweak
4c17ece
@bobzhang
bs.optional and optional
798bd23
@bobzhang
snapshot
415d6df
@bobzhang
prepare critical external transition
dabb255
@bobzhang
add bs.get/bs.set transition
dbd586f 
Test case:
make sure [@@set] [@@ocaml.doc] [@@deprecaetd] integrate well
@bobzhang
snapshot
b94414e
@bobzhang
fix ci
24e91d8
@bobzhang
bs.get_index/bs.set_index transition
1bcbe5b
@bobzhang
snapshot
67c0c09
@bobzhang
accept both bs.return and return
54063ba
@bobzhang bobzhang changed the title WIP: bs.xx -> xx transition bs.xx -> xx transition, no bs prefix needed Sep 17, 2020
@bobzhang bobzhang merged commit 8265044 into master Sep 17, 2020
@chenglou chenglou deleted the clean_up_attributes branch September 18, 2020 15:28
@Coobaha Coobaha mentioned this pull request Oct 3, 2020
Merged
@ELLIOTTCABLE ELLIOTTCABLE mentioned this pull request Jan 15, 2021
Merged
@anmonteiro anmonteiro mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobzhang